From ab5e5473cb18c7c2c815f28a1c3317928ef6552f Mon Sep 17 00:00:00 2001
From: Innei <tukon479@gmail.com>
Date: Thu, 28 Jul 2022 21:42:51 +0800
Subject: [PATCH] refactor: scan table cron

Signed-off-by: Innei <tukon479@gmail.com>
---
 src/processors/helper/helper.cron.service.ts | 43 ++++++++++++++++++
 src/processors/helper/helper.jwt.service.ts  | 47 ++------------------
 2 files changed, 46 insertions(+), 44 deletions(-)

diff --git a/src/processors/helper/helper.cron.service.ts b/src/processors/helper/helper.cron.service.ts
index 75b96786..9d25ecaf 100644
--- a/src/processors/helper/helper.cron.service.ts
+++ b/src/processors/helper/helper.cron.service.ts
@@ -28,6 +28,7 @@ import { getRedisKey } from '~/utils/redis.util'
 
 import { CacheService } from '../redis/cache.service'
 import { HttpService } from './helper.http.service'
+import { JWTService, StoreJWTPayload } from './helper.jwt.service'
 
 @Injectable()
 export class CronService {
@@ -54,6 +55,8 @@ export class CronService {
     private readonly backupService: BackupService,
     @Inject(forwardRef(() => SearchService))
     private readonly searchService: SearchService,
+    @Inject(forwardRef(() => JWTService))
+    private readonly jwtService: JWTService,
   ) {
     this.logger = new Logger(CronService.name)
   }
@@ -324,4 +327,44 @@ export class CronService {
       throw err
     }
   }
+  @CronDescription('扫表：删除过期 JWT')
+  @CronOnce(CronExpression.EVERY_DAY_AT_1AM, {
+    name: 'deleteExpiredJWT',
+  })
+  async deleteExpiredJWT() {
+    this.logger.log('--> 开始扫表，清除过期的 token')
+    const redis = this.cacheService.getClient()
+    const keys = await redis.hkeys(getRedisKey(RedisKeys.JWTStore))
+    let deleteCount = 0
+    await Promise.all(
+      keys.map(async (key) => {
+        const value = await redis.hget(getRedisKey(RedisKeys.JWTStore), key)
+        if (!value) {
+          return null
+        }
+        const parsed = JSON.safeParse(value) as StoreJWTPayload
+        if (!parsed) {
+          return null
+        }
+
+        const date = dayjs(new Date(parsed.date))
+        if (date.add(JWTService.expiresDay, 'd').diff(new Date(), 'd') < 0) {
+          this.logger.debug(
+            `--> 删除过期的 token：${key}, 签发于 ${date.format(
+              'YYYY-MM-DD H:mm:ss',
+            )}`,
+          )
+
+          return await redis
+            .hdel(getRedisKey(RedisKeys.JWTStore), key)
+            .then(() => {
+              deleteCount += 1
+            })
+        }
+        return null
+      }),
+    )
+
+    this.logger.log(`--> 删除了 ${deleteCount} 个过期的 token`)
+  }
 }
diff --git a/src/processors/helper/helper.jwt.service.ts b/src/processors/helper/helper.jwt.service.ts
index 2a665534..0e463b83 100644
--- a/src/processors/helper/helper.jwt.service.ts
+++ b/src/processors/helper/helper.jwt.service.ts
@@ -1,13 +1,10 @@
 import cluster from 'cluster'
-import dayjs from 'dayjs'
 import { sign, verify } from 'jsonwebtoken'
 import { machineIdSync } from 'node-machine-id'
 
 import { Injectable, Logger } from '@nestjs/common'
-import { CronExpression } from '@nestjs/schedule'
 
 import { CLUSTER, SECURITY } from '~/app.config'
-import { CronOnce } from '~/common/decorator/cron-once.decorator'
 import { RedisKeys } from '~/constants/cache.constant'
 import { getRedisKey, md5 } from '~/utils'
 
@@ -110,56 +107,18 @@ export class JWTService {
     )
   }
 
-  private readonly expiresDay = SECURITY.jwtExpire
+  public static readonly expiresDay = SECURITY.jwtExpire
 
   sign(id: string, info?: { ip: string; ua: string }) {
     const token = sign({ id }, this.secret, {
-      expiresIn: `${this.expiresDay}d`,
+      expiresIn: `${JWTService.expiresDay}d`,
     })
     this.storeTokenInRedis(token, info || {})
     return token
   }
-
-  @CronOnce(CronExpression.EVERY_DAY_AT_1AM)
-  async scanTable() {
-    this.logger.log('--> 开始扫表，清除过期的 token')
-    const redis = this.cacheService.getClient()
-    const keys = await redis.hkeys(getRedisKey(RedisKeys.JWTStore))
-    let deleteCount = 0
-    await Promise.all(
-      keys.map(async (key) => {
-        const value = await redis.hget(getRedisKey(RedisKeys.JWTStore), key)
-        if (!value) {
-          return null
-        }
-        const parsed = JSON.safeParse(value) as StoreJWTPayload
-        if (!parsed) {
-          return null
-        }
-
-        const date = dayjs(new Date(parsed.date))
-        if (date.add(this.expiresDay, 'd').diff(new Date(), 'd') < 0) {
-          this.logger.debug(
-            `--> 删除过期的 token：${key}, 签发于 ${date.format(
-              'YYYY-MM-DD H:mm:ss',
-            )}`,
-          )
-
-          return await redis
-            .hdel(getRedisKey(RedisKeys.JWTStore), key)
-            .then(() => {
-              deleteCount += 1
-            })
-        }
-        return null
-      }),
-    )
-
-    this.logger.log(`--> 删除了 ${deleteCount} 个过期的 token`)
-  }
 }
 
-interface StoreJWTPayload {
+export interface StoreJWTPayload {
   /**
    * ISODateString
    */